Skip to content

Replace abandoned addon luanti with new one with almost full docs, … - #285

Closed
alek13 wants to merge 1 commit into
LuaLS:mainfrom
alek13:replace-Luanti-with-full-version
Closed

Replace abandoned addon luanti with new one with almost full docs, …#285
alek13 wants to merge 1 commit into
LuaLS:mainfrom
alek13:replace-Luanti-with-full-version

Conversation

@alek13

@alek13 alek13 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

…and which is actively maintained & supported by community.

Important

This PR

  • removes old and abandoned addon
  • add new one instead
  • ⚠️ also applies changes (remove/add) into .gitmodules ⚠️

Please, tell us how it will be better to make replacement ?
It seems like the submodule deletion is not processed (.github/workflows/pull_request.yml).


EDIT:
also pipeline fails attempting to commit back to our repo:

remote: Permission to Voxrame/LLS-Addons-Fork.git denied to github-actions[bot].

Maybe it because of not allowed edits from maintainers (but not sure if it's the only reason).
It seems like there is no way to allow edits for organizations forks, only for personal.

…and which is activly maintained & supported by community.
@alek13

alek13 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

@carsakiller , can you help us with questions.

@carsakiller

Copy link
Copy Markdown
Collaborator

Sorry for the delay, I've been sick the last few days.

I'm not sure the current Luanti addon could be called abandoned, it has been 5 months since it has had a commit, but that shouldn't mean that the addon be outright replaced here. Unless @fgaz agrees to swapping the name over to this repository instead. Otherwise, it is best that this addon be added under its own unique name.

As for the pipeline, yes, it requires the ability to edit your branch in order to add the needed metadata for the addon manager. If an organization-owned fork is not allowed to allow edits, then I'd ask that you make a personal fork and open the PR from there.

@fgaz

fgaz commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Thanks for the ping @carsakiller.

The addon isn't abandoned, I've just been very slowly going through this massive pr https://codeberg.org/fgaz/luanti-lls-definitions/pulls/1

I'll try to merge it this week

@fgaz

fgaz commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

It's unfortunate that there has been so much duplicate work, but I see that the two addons are slightly different:

So I think they can coexist

alek13 added a commit to alek13/LLS-Addons-Fork that referenced this pull request Oct 20, 2025
alek13 added a commit to alek13/LLS-Addons-Fork that referenced this pull request Oct 20, 2025
@alek13 alek13 closed this Oct 20, 2025
carsakiller pushed a commit that referenced this pull request Oct 23, 2025
* Add addon "Luanti Full API". Replaces #285

* chore: Update Addon Metadata

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants