Make replicaCount optional in monochart (#28)

Lowess · Jul 1, 2022 · 64f25be · 64f25be
1 parent 00d45aa
commit 64f25be
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/charts/monochart/Chart.yaml b/charts/monochart/Chart.yaml
@@ -1,8 +1,8 @@
 apiVersion: v1
 description: A declarative helm chart for deploying common types of services on Kubernetes
 name: monochart
-version: 0.25.1
-appVersion: 0.25.1
+version: 0.25.2
+appVersion: 0.25.2
 home: https://github.com/Lowess/charts/tree/master/charts/monochart
 icon: https://raw.githubusercontent.com/cloudposse/charts/master/incubator/monochart/logo.png
 maintainers:

diff --git a/charts/monochart/templates/deployment.yaml b/charts/monochart/templates/deployment.yaml
@@ -13,7 +13,9 @@ metadata:
 {{ toYaml .| indent 4 }}
 {{- end }}
 spec:
-  replicas: {{ .Values.replicaCount }}
+{{- with .Values.replicaCount }}
+  replicas: {{ . }}
+{{- end }}
   selector:
     matchLabels:
       app: {{ include "common.name" . }}

diff --git a/charts/monochart/values.example.yaml b/charts/monochart/values.example.yaml
@@ -1,4 +1,4 @@
-replicaCount: 1
+replicaCount: null
 
 serviceAccountName: my-service-account
 

diff --git a/charts/monochart/values.yaml b/charts/monochart/values.yaml
@@ -1,3 +1,4 @@
+# replicaCount can be set to null to be omitted and let HPA take over
 replicaCount: 1
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,4 @@
		# replicaCount can be set to null to be omitted and let HPA take over
		replicaCount: 1


Expand Down