Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA translation for remote device #239

Merged
merged 28 commits into from
Jan 21, 2025
Merged

JA translation for remote device #239

merged 28 commits into from
Jan 21, 2025

Conversation

NovaDNG
Copy link
Contributor

@NovaDNG NovaDNG commented Jan 21, 2025

Summary by Sourcery

Documentation:

  • Add Japanese translations.

Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request adds Japanese translations for remote device functionality. It includes translations for standard Japanese, Japanese Kana, and Japanese Nise.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Japanese translations for remote device functionality.
  • Added translations to intl_ja.arb.
  • Added translations to intl_ja_Kana.arb.
  • Added translations to intl_ja_Nise.arb.
lib/l10n/intl_ja.arb
lib/l10n/intl_ja_Kana.arb
lib/l10n/intl_ja_Nise.arb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NovaDNG - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide the complete diff showing the actual translation changes being made to these files.
  • Could you clarify the purpose of the 'Nise' variant translation file? Is this intended for testing?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the C - l10n Localization related issue label Jan 21, 2025
@Losses Losses merged commit 92955fa into Losses:master Jan 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - l10n Localization related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants