Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE: fix(iOS): Support secure bookmarks #227

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Jan 4, 2025

Previous #221

Summary by Sourcery

Enhancements:

  • Pin macos_secure_bookmarks to commit c07abbf7c186c543de09a9c7df8577bbf5e27748.

Copy link

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This pull request updates the macos_secure_bookmarks dependency to use a specific commit from a forked repository. This addresses an issue where secure bookmarks were not being supported on iOS.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the macos_secure_bookmarks dependency
  • Replaced the versioned dependency with a git dependency pointing to a specific commit hash.
  • Updated the pubspec.lock file to reflect the change in the dependency
pubspec.yaml
pubspec.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dosubot dosubot bot added the C - dependencies Pull requests that update a dependency file label Jan 4, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Using a Git dependency instead of a published package version introduces availability risks and should be avoided when possible. Consider using a published version of macos_secure_bookmarks, or if this specific commit is required, please document the rationale in the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 48810b6 into Losses:master Jan 5, 2025
1 of 2 checks passed
@Losses Losses deleted the ios_secure_bookmarks branch January 5, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants