-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative Insulin Damper #2247
Open
motinis
wants to merge
17
commits into
LoopKit:dev
Choose a base branch
from
motinis:negative-insulin-damper
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Negative Insulin Damper #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By construction it should never occur, but safeguards should enforce this.
Control NID recalculation independently
Also clear damper alongside cached insulin effects - this helps e.g. if non-pump insulin is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in zulip chat. The implementation relies on the idea described in this message. The implementation in practice linearly scales alpha in an initial section (in practice until delta is 90), at which point the slop of alpha*delta is 0.1. This slope is then continued on in the second section.
The calibration done was based on alpha=0.75 at delta=50; this was estimated to be approximately an hour of withdrawn basal. Note that with an alpha=0.75, this means the result would have 37.5, or be 12.5 mg/dL lower than otherwise. With auto-bolusing, this would result in giving a bolus which would result in 5 mg/dL less effect, which is quite minimal. As negative IOB increases the resulting alpha gets significantly smaller.
Additional testing is necessary for this PR before merging.