Strategy partial sale for fixed price #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some marketplaces, Rarible for instance, allow partial sales. I mean, if an offer is a sale of 5 items, you can buy 3 out of 5.
This PR delivers a strategy that do the same here. An offer is active until cancelled or the amount is in the offer is fully used.
When using a part of the offer, the price is not always divisible and rounding is required. Therefore the strategy checks this condition
A little change in the LooksRare core contracts is required. Luckily it enables another strategies, for instance a dutch auction with large number of items to be bought one by one.