feat: preserve email on feedback form, optionally

[Samathingamajig]

Screen.Recording.2025-06-08.at.11.38.35.PM.mov

---

This change is 

[DereC4]

Is storing the email itself in optionsStore a good idea?

[Samathingamajig]

Is storing the email itself in optionsStore a good idea?

seems like the best place to put it without making a separate store just for it, open to other thoughts.

maybe a userDataStore? but I can't really think of other kinds of things we'd need for that.

a boolean for whether to save the email is probably an "option", and it makes some sense to me to keep the email data nearby. Don't want to overload the types to be false for not storing and string when storing, that is too confusing

[DereC4]

Is storing the email itself in optionsStore a good idea?

seems like the best place to put it without making a separate store just for it, open to other thoughts.

maybe a userDataStore? but I can't really think of other kinds of things we'd need for that.

a boolean for whether to save the email is probably an "option", and it makes some sense to me to keep the email data nearby. Don't want to overload the types to be false for not storing and string when storing, that is too confusing

hm mayb idk it could be a good setup for any future things that need to be stored

[Samathingamajig]

Is storing the email itself in optionsStore a good idea?

seems like the best place to put it without making a separate store just for it, open to other thoughts.
maybe a userDataStore? but I can't really think of other kinds of things we'd need for that.
a boolean for whether to save the email is probably an "option", and it makes some sense to me to keep the email data nearby. Don't want to overload the types to be false for not storing and string when storing, that is too confusing

hm mayb idk it could be a good setup for any future things that need to be stored

i guess

[Razboy20]

Generally, code changes look good to me. (still need to test as a build though).

Let's remove 'rememberMyEmail' as a setting stored in options, and rather infer this from whether an email is saved or not.

If a user decides to unselect remember my email, then unset email in options store.

[Razboy20]

If an email is set, can we not consider this to be indicative of the email being remembered? Think 'rememberMyEmail' could be removed.

[Samathingamajig]

will look into this @Razboy20