style: UTRP-14: Add a bigger "hitbox" to calendar sidebar buttons #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjpark
changed the title
aaronjpark
changed the title
|
Are the screenshots up to date? If so, the spacing should not be affected |
|
why has this still not been merged bruh i thought we got over it eons ago |
Razboy20
requested changes
Aug 27, 2025
There was a problem hiding this comment.
Let's refactor this to not adjust the actual spacing and placement of the icons, but use ::after with inset.
Take a look at this article: https://51bits.com/expanded-hit-areas/
Razboy20
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "potentially" closes #519
[Task 1 - Make the HitBox Area of Sidebar and Plus Buttons Bigger]
DISCLAIMER: the screenshot only shows the sidebar button. All 3 buttons (sidebar, +, settings) have been changed.
Before: the size of the hitbox for most of the sidebar buttons were extremely small:
after: changed the size prop to small to make the hitbox area bigger:
[Task 2 - Make the HitBox Area of Social Links Bigger]
DISCLAIMER: #519 doesn't specify how big the hitbox for the social links should be. Talked to Derek in-person and Derek said p-2 looks good. The Red Borders were added for visual reference.
before:
after:
This change is