OSOE-392: Upgrade to Orchard Core 1.5 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Use more descriptive commit messages than "Updating Lombiq.UITestingToolbox". |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
OSOE-483: Randomly failing UI tests, when upgrading to OC 1.5 in Lombiq.UITestingToolbox
Piedone
requested changes
Dec 6, 2022
NuGetTest/test/Lombiq.OSOCE.NuGet.Tests.UI/Lombiq.OSOCE.NuGet.Tests.UI.csproj
Outdated
Show resolved
Hide resolved
Piedone
approved these changes
Dec 6, 2022
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (1)Embedd Previously acknowledged words that are now absentabcdef Airi chromedriver editorconfig enableextensions eur favicon Hsl https iis itemprop json labelledby linq localhost lockfile markdownlint mscorlib mvc myapp ndproj NPM Panem pnpm pragma publishsettings Reks Rekt RSPEC setlocal SFCs sourcemaps sql uri wpf yaml ymlTo accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Lombiq/Open-Source-Orchard-Core-Extensions.git repository update_files() {
mkdir -p '.github/actions/spelling/'
cp -i -R $(
cd $(mktemp -d)
git clone --depth 1 --no-tags https://github.com/Lombiq/GitHub-Actions --branch dev . > /dev/null 2> /dev/null
cd '.github/actions/spelling/'; pwd
)/* '.github/actions/spelling/'
git add '.github/actions/spelling/'
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}
comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/Lombiq/Open-Source-Orchard-Core-Extensions/issues/comments/1339925190" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" | tr -d "\\r" > $comment_body
rm $comment_json
patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")
update_files
rm $comment_body
git add -u
Available 📚 dictionaries could cover words not in the 📘 dictionaryThis includes both expected items (227) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them using (in with:
extra_dictionaries:
cspell:cpp/src/cpp.txt
cspell:software-terms/src/software-terms.txt
cspell:node/node.txt
cspell:python/src/python/python-lib.txt
cspell:php/php.txtTo stop checking additional dictionaries, add: with:
check_extra_dictionaries: ''Warnings (1)See the 📂 files view or the 📜action log for details.
See ℹ️ Event descriptions for more information. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (1)Embedd Previously acknowledged words that are now absentabcdef Airi chromedriver editorconfig enableextensions eur favicon Hsl https iis itemprop json labelledby linq localhost lockfile markdownlint mscorlib mvc myapp ndproj NPM Panem pnpm pragma publishsettings Reks Rekt RSPEC setlocal SFCs sourcemaps sql uri wpf yaml ymlTo accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Lombiq/Open-Source-Orchard-Core-Extensions.git repository update_files() {
mkdir -p '.github/actions/spelling/'
cp -i -R $(
cd $(mktemp -d)
git clone --depth 1 --no-tags https://github.com/Lombiq/GitHub-Actions --branch dev . > /dev/null 2> /dev/null
cd '.github/actions/spelling/'; pwd
)/* '.github/actions/spelling/'
git add '.github/actions/spelling/'
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}
comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"COMMENT_URL" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" | tr -d "\\r" > $comment_body
rm $comment_json
patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")
update_files
rm $comment_body
git add -u
Available 📚 dictionaries could cover words not in the 📘 dictionaryThis includes both expected items (227) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them using (in with:
extra_dictionaries:
cspell:cpp/src/cpp.txt
cspell:software-terms/src/software-terms.txt
cspell:node/node.txt
cspell:python/src/python/python-lib.txt
cspell:php/php.txtTo stop checking additional dictionaries, add: with:
check_extra_dictionaries: ''Warnings (1)See the 📂 files view or the 📜action log for details.
See ℹ️ Event descriptions for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
OSOE-392