Skip to content

Conversation

@Lokowitz
Copy link
Owner

@Lokowitz Lokowitz commented Dec 3, 2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

How to test?

@gemini-code-assist
Copy link

Summary of Changes

Hello @Lokowitz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant internal refactoring by switching the underlying SQLite database driver from better-sqlite3 to @libsql/client. This change modernizes the database interaction layer, affecting dependency management, database initialization, and the execution patterns for SQL queries and migration scripts throughout the codebase. The update aims to leverage the capabilities of the new client for improved database operations.

Highlights

  • Database Driver Migration: The core change involves migrating the SQLite database driver from better-sqlite3 to @libsql/client across the application. This updates how the database is initialized and interacted with.
  • Dependency Updates: The package.json and package-lock.json files have been updated to reflect the removal of better-sqlite3 and its types, and the addition of @libsql/client and its associated packages.
  • Database Interaction API Changes: Database operations in various files, including migration scripts, have been refactored to use the asynchronous await db.execute() method provided by @libsql/client, replacing synchronous db.prepare().run() and db.transaction() calls.
  • Error Handling Update: Error handling for database constraints has been updated to catch LibsqlError instead of SqliteError, aligning with the new database client.
  • Application Version Bump: The application version has been incremented from 1.12.1 to 1.13.0 in server/lib/consts.ts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches the database driver from better-sqlite3 to @libsql/client. While the changes to the main application code for error handling and driver initialization look correct, the migration scripts in server/setup/scriptsSqlite/ have been refactored in a way that introduces critical bugs. The original scripts correctly used transactions to ensure migrations are atomic, but these have been removed. Additionally, multi-statement SQL queries are now being passed to @libsql/client's execute method, which only supports single statements, and will cause migrations to fail. Please review the detailed comments on the migration scripts to address these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants