Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Implement block.json generation when caching #224

Merged
merged 10 commits into from
Mar 1, 2024
Merged

Conversation

Log1x
Copy link
Owner

@Log1x Log1x commented Mar 1, 2024

This is a WIP attempt at generating and using block.json files when running acf:cache for #223

It still needs style/script support but I haven't figured out the best way to pull that off while maintaining some kind of compatibility with assets().

Please test using composer require log1x/acf-composer:dev-feat/json-blocks and then compile with acorn acf:cache.

@Log1x Log1x marked this pull request as ready for review March 1, 2024 13:44
@Log1x Log1x self-assigned this Mar 1, 2024
@Log1x Log1x added the help wanted Extra attention is needed label Mar 1, 2024
@Log1x
Copy link
Owner Author

Log1x commented Mar 1, 2024

I'm noticing a massive unexpected increase in performance when loading custom blocks in the editor. The loading indicator is non-existent now for pages with multiple blocks. ⚡

@Log1x Log1x merged commit e66d462 into master Mar 1, 2024
2 checks passed
@Log1x Log1x deleted the feat/json-blocks branch March 1, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant