New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shell escaping in networking config #854

Merged

Enzime merged 1 commit into LnL7:master from erratic-pattern:fix/network-names-shell-escapes

Jan 21, 2024

Contributor

erratic-pattern commented Jan 19, 2024

Fix a bug where using a single quote in any of the networking names caused the following error:

/nix/store/8zbx7q8xxrsd46m0n0bspnjvm27ak3sr-darwin-system-24.05.20240108.317484b+darwin4.0dd382b/activate: line 264: unexpected EOF while looking for matching `''

Example config:

  networking.hostName = "Adams-MacBook-Pro";
  networking.computerName = "Adam's MacBook Pro";


          fix shell escaping in networking config

5cec74d

Enzime approved these changes

View reviewed changes

Collaborator

Enzime left a comment

LGTM

Thanks for the contribution 👍

Enzime merged commit 3ac7acd into LnL7:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet