Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeterminateSystems installer 0.32.2 support #1234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

x13-me
Copy link

@x13-me x13-me commented Dec 22, 2024

Add DeterminateSystems Nix installer 0.32.2 to known hashes

Add DeterminateSystems Nix installer `0.32.2` to known hashes
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a copy of the file to docs/known-files?

@emilazy
Copy link
Collaborator

emilazy commented Jan 8, 2025

@x13-me Friendly ping :) The commit message should also look like nix: add Determinate Systems Nix installer 0.32.2 to known hashes.

Would you like someone else to take this PR over?

@x13-me
Copy link
Author

x13-me commented Jan 8, 2025

@x13-me Friendly ping :) The commit message should also look like nix: add Determinate Systems Nix installer 0.32.2 to known hashes.

Would you like someone else to take this PR over?

Please hand to someone else; personal life has pulled me away

@x13-me
Copy link
Author

x13-me commented Jan 12, 2025

Can you add a copy of the file to docs/known-files?

I've uploaded the file as a gist, because github won't allow me to attach a .conf to a comment, I believe this preserves the file hash, it is as-installed on my system, no modifications

@emilazy
Copy link
Collaborator

emilazy commented Jan 13, 2025

It looks like that’s the hash from an activated nix-darwin configuration. When installing with v0.32.2 locally I seem to get a configuration matching a hash we already have and it activates without issue. Are you perhaps trying to reinstall nix-darwin after having already installed it?

@x13-me
Copy link
Author

x13-me commented Jan 14, 2025

It looks like that’s the hash from an activated nix-darwin configuration. When installing with v0.32.2 locally I seem to get a configuration matching a hash we already have and it activates without issue. Are you perhaps trying to reinstall nix-darwin after having already installed it?

Not as far as I'm aware, this was a complete fresh install, no doubt I've done something wrong though

@Enzime
Copy link
Collaborator

Enzime commented Jan 14, 2025

When I hash the file you linked, it gives a different hash to the hash you added in this PR:

$ curl https://gist.githubusercontent.com/x13-me/ef53cfa6ebf8e9f37db43dd08c9a25f7/raw/9eb2c1c05c0f038310a93d9959c981d3ac459c9f/kyf3mhhn565qhc2rzfaglig39m7yij1r-nix.conf | shasum -a 256
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   518  100   518    0     0   1242      0 --:--:-- --:--:-- --:--:--  1245
7ac9c0f815d09e16449c9733e5a2bcf2ddf925f938a3b4eb1267e1eb0ded4b66  -

This should work correctly as the other files in doc/known-files work:

$ curl https://raw.githubusercontent.com/LnL7/nix-darwin/refs/heads/master/doc/known-files/0235d3c1b6cf21e7043fbc98e239ee4bc648048aafaf6be1a94a576300584ef2 | shasum -a 256
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   255  100   255    0     0    528      0 --:--:-- --:--:-- --:--:--   529
0235d3c1b6cf21e7043fbc98e239ee4bc648048aafaf6be1a94a576300584ef2  -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants