Skip to content

build(homebrew): Update CUDA argument check in sunshine.rb#5065

Draft
ReenigneArcher wants to merge 1 commit intomasterfrom
ReenigneArcher-patch-1
Draft

build(homebrew): Update CUDA argument check in sunshine.rb#5065
ReenigneArcher wants to merge 1 commit intomasterfrom
ReenigneArcher-patch-1

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

Description

Fixing build.with argument as pointed out in LizardByte/homebrew-homebrew#245 (comment)

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.06%. Comparing base (bdef150) to head (e878ab4).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5065      +/-   ##
==========================================
- Coverage   18.18%   18.06%   -0.13%     
==========================================
  Files         109      109              
  Lines       23570    23565       -5     
  Branches    10398    10394       -4     
==========================================
- Hits         4287     4257      -30     
+ Misses      17746    15882    -1864     
- Partials     1537     3426    +1889     
Flag Coverage Δ
Archlinux 11.53% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.76% <ø> (ø)
Homebrew-ubuntu-22.04 13.90% <ø> (ø)
Linux-AppImage ?
Windows-AMD64 14.86% <ø> (ø)
Windows-ARM64 13.25% <ø> (ø)
macOS-arm64 19.07% <ø> (ø)
macOS-x86_64 18.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 47 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdef150...e878ab4. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher marked this pull request as draft May 2, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant