Add macOS left Alt to Command mapping option#5064
Open
bdjben wants to merge 1 commit intoLizardByte:masterfrom
Open
Add macOS left Alt to Command mapping option#5064bdjben wants to merge 1 commit intoLizardByte:masterfrom
bdjben wants to merge 1 commit intoLizardByte:masterfrom
Conversation
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This adds an opt-in macOS input setting,
key_leftalt_to_key_cmd, that maps Moonlight's Left Alt key (VKEY_LMENU) to the left macOS Command key.The mapping happens in the macOS platform key translation layer rather than through
keybindings. This matters becausekeybindings = [0xA4, 0x5B]remaps the key before Sunshine updates its internal modifier state; later key packets that still carry the Alt modifier can then cause Sunshine to synthesize Option in addition to Command. By leaving the core keycode asVKEY_LMENUand only changing the macOS virtual key emitted to CoreGraphics, Sunshine continues to track Alt internally while macOS receives Command.This is useful for macOS hosts accessed from clients or operating systems that intercept the Windows key before Moonlight can send it, but can still send Left Alt.
Changes
key_leftalt_to_key_cmd, default disabled.src/platform/macos/input.cpp.Testing
git diff --checkjq emptyon updated English locale JSON filesnpm install --no-package-lock --no-audit --no-fundnpm run build