Skip to content

feat(linux/xdgportal): Add support for pipewire-serial#5060

Draft
Kishi85 wants to merge 1 commit intoLizardByte:masterfrom
Kishi85:draft-xdgportal-pipewire-serial
Draft

feat(linux/xdgportal): Add support for pipewire-serial#5060
Kishi85 wants to merge 1 commit intoLizardByte:masterfrom
Kishi85:draft-xdgportal-pipewire-serial

Conversation

@Kishi85
Copy link
Copy Markdown
Contributor

@Kishi85 Kishi85 commented Apr 29, 2026

Description

This is a PR to implement the upcoming changes on XDG portal to utilize pipewire-serial for stream selection instead of pipewire's node id. For more information see: flatpak/xdg-desktop-portal#979

The groundwork for using object serial with pipewire.cpp was done in #5054. This PR contains the changes to pass the serial received from XDG portal forward to pipewire_display_t.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85
Copy link
Copy Markdown
Contributor Author

Kishi85 commented Apr 29, 2026

Let's leave this as a draft for now until the changes are merged to/available on xdg-desktop-portal and this can be properly tested.

@Kishi85 Kishi85 force-pushed the draft-xdgportal-pipewire-serial branch from d04bca7 to a9e9764 Compare April 29, 2026 13:03
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher added this to the xdg portal grab milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants