fix(linux): wrong render_node selection in linux#4959
Closed
Clutchnp wants to merge 2 commits intoLizardByte:masterfrom
Closed
fix(linux): wrong render_node selection in linux#4959Clutchnp wants to merge 2 commits intoLizardByte:masterfrom
Clutchnp wants to merge 2 commits intoLizardByte:masterfrom
Conversation
Member
|
Is your issue fixed by #4946 ? |
Contributor
Author
|
no that's separate |
|
Bundle ReportChanges will decrease total bundle size by 788.77kB (-50.1%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
+ Coverage 17.35% 19.47% +2.12%
==========================================
Files 107 84 -23
Lines 23136 17522 -5614
Branches 10103 7882 -2221
==========================================
- Hits 4015 3413 -602
+ Misses 15025 11258 -3767
+ Partials 4096 2851 -1245
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
I would like to integrate this in #4961, hence closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
so what was happening is in the wayland.cpp file we were picking the first drm device we found as gbm device, even if in the config it was something else, this is critical in the case of systems with 2 gpus and caused crahses on my system, which has both an nvidia and amd gpu. This pr fixes that
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage