Skip to content

fix(linux): wrong render_node selection in linux#4959

Closed
Clutchnp wants to merge 2 commits intoLizardByte:masterfrom
Clutchnp:master
Closed

fix(linux): wrong render_node selection in linux#4959
Clutchnp wants to merge 2 commits intoLizardByte:masterfrom
Clutchnp:master

Conversation

@Clutchnp
Copy link
Copy Markdown
Contributor

@Clutchnp Clutchnp commented Apr 7, 2026

Description

so what was happening is in the wayland.cpp file we were picking the first drm device we found as gbm device, even if in the config it was something else, this is critical in the case of systems with 2 gpus and caused crahses on my system, which has both an nvidia and amd gpu. This pr fixes that

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Clutchnp Clutchnp changed the title fix wrong render_node selection in linux fix(linux): wrong render_node selection in linux Apr 7, 2026
@ReenigneArcher
Copy link
Copy Markdown
Member

Is your issue fixed by #4946 ?

@Clutchnp
Copy link
Copy Markdown
Contributor Author

no that's separate

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Bundle Report

Changes will decrease total bundle size by 788.77kB (-50.1%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
rapideye-esm (removed) -788.77kB (-100.0%) ⬇️

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.47%. Comparing base (3527320) to head (dbceb94).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/wayland.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
+ Coverage   17.35%   19.47%   +2.12%     
==========================================
  Files         107       84      -23     
  Lines       23136    17522    -5614     
  Branches    10103     7882    -2221     
==========================================
- Hits         4015     3413     -602     
+ Misses      15025    11258    -3767     
+ Partials     4096     2851    -1245     
Flag Coverage Δ
Archlinux 11.60% <0.00%> (-0.01%) ⬇️
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.58% <0.00%> (-0.02%) ⬇️
Homebrew-ubuntu-22.04 13.93% <0.00%> (+0.01%) ⬆️
Linux-AppImage 12.20% <0.00%> (-0.01%) ⬇️
Windows-ARM64 ?
macOS-arm64 19.02% <ø> (ø)
macOS-x86_64 18.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/wayland.cpp 2.95% <0.00%> (-0.04%) ⬇️

... and 61 files with indirect coverage changes

@Clutchnp
Copy link
Copy Markdown
Contributor Author

I would like to integrate this in #4961, hence closing for now

@Clutchnp Clutchnp closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants