fix(homebrew): move binary after build and codesign

[soerenkampschroer]

Description

Moving binary after build and adding codesign as per issue #3340

Screenshot

Issues Fixed or Closed

Fixes issue #3340

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[ReenigneArcher]

Failures are a bit hard to find so I'm pasting them here:

  Error: 1 problem in 1 formula detected.
    * line 122, col 56: Use `bin/"sunshine"` instead of `"#{bin}/sunshine"`
  Error:  Process [['brew', 'audit', '--os=all', '--arch=all', '--strict', '--online', 'homebrew-release-action/homebrew-test/sunshine']] failed with exit code 1
  Error:  Formula sunshine failed audit

And on Linux we probably need to make this conditional? Or use an alternative.

==> codesign -s - --force --deep /home/linuxbrew/.linuxbrew/Cellar/sunshine/0.0.3347/bin/sunshine
Failed to execute: codesign

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.14%. Comparing base (ec0cdcf) to head (37795b2).

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #3347    +/-   ##
========================================
  Coverage   11.14%   11.14%            
========================================
  Files          99       99            
  Lines       17186    17186            
  Branches     8009     8009            
========================================
  Hits         1916     1916            
+ Misses      12724    12582   -142     
- Partials     2546     2688   +142     

Flag	Coverage Δ
Linux	8.45% <ø> (ø)
Windows	5.22% <ø> (ø)
macOS-13	13.66% <ø> (+0.01%)	⬆️
macOS-14	12.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

[soerenkampschroer]

Oh I wasn't aware this would impact building for Linux as well.
I haven't used Linux in a while, so I don't know if signing is even a thing there. But as it is, it should be conditional only to macOS.

Also I've discovered that the moving part isn't really moving but copying. The build folder will contain two identical binaries, sunshine and sunshine-v2024.XXXX.XXXX. That doesn't bother me personally because the binary is quite small, but maybe there is a better way. The whole copy thing only really matters for macOS too, so that should probably also be conditional.

[ReenigneArcher]

Yea, the install will just install that file again. I don't think it's a huge deal as our binary is quite small. There's probably a way to remove the original versioned binary filename though.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud