Fix/tiling layout issues #1605
Merged
Fix/tiling layout issues #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
fix/tiling-layout-issues
branch
from
4e530e7
to
a8e2659
Compare
merryman
force-pushed
the
fix/tiling-layout-issues
branch
2 times, most recently
from
7e203c6
to
0cf1e47
Compare
linusha
force-pushed
the
fix/tiling-layout-issues
branch
from
af3f4cf
to
ea0b014
Compare
merryman
force-pushed
the
fix/tiling-layout-issues
branch
2 times, most recently
from
d918d82
to
1027770
Compare
Previously, if not passing the extent, yoga would assume dynamic height or width (when filling owner) to be 0 which is nonesense.
This replaces the previous integration of yoga-layout to support the tiling layouts in lively.next. Overall the initial approach was to tightly couple morphs and their bounds to the yoga nodes and utilize the yoga nodes like “abstract twins“ to compute the layout. This was problematic, since yoga does not like to be evaluated/executed on a per morph level, but instead works best when the layout is continously updated form the top most layout (the morph on top of a layout composition). As a result, this change tries to adhere more to the execution scheme that yoga prefers, making a bunch of hacky adjustments that were previously found in the code unnessecary.
Previously the default browser behavior was preventing a morph from shrinking beyond its submorph bounds when resized vertically by a layout.
This saves a bunch unnessecary compute cycles, improving performance.
Layouts would update the actual bounds of a morph too late, so that the breakpoints whould not get activated on time. We now move the updates for breakpoint affected morphs to an earlier point.
linusha
force-pushed
the
fix/tiling-layout-issues
branch
from
1027770
to
b14cae3
Compare
linusha
reviewed
Jul 22, 2024
| @@ -1052,7 +1052,7 @@ export class StylePolicy { | |||
| */ | |||
| synthesizeSubSpec (submorphNameInPolicyContext, ownerOfScope, previousTarget) { | |||
| const isRoot = !submorphNameInPolicyContext; | |||
| const transformProps = ['extent', 'position', 'rotation', 'scale', 'lineHeight']; | |||
| const transformProps = ['extent', 'position', 'scale', 'lineHeight']; | |||
There was a problem hiding this comment.
"apply rotation for root of component for now" - why only 'for now'?
There was a problem hiding this comment.
Because I am not yet sure if we run into unintended consequences. The reason I excluded transform properties from being applied to a morph when it is the root is that we mostly dont want that, even if these properties are not explicitly overridden.
For instance if we do not exclude the position from being applied to the root, it will lead to weird jump behaviors of morphs that suddenly align at positions that make no sense in the context they are in. For now I assume that rotation is seldomly defined at all, so it wont cause any issue. Also since it is applied so rarely you would assume that if a rotation is applied, it is there for a good reason.
linusha
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a broken fill behavior and invalid margin computation in the tiling layout.