Updated PS1 sigscans #109
Open
Updated PS1 sigscans #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
reviewed
Jun 19, 2025
Comment on lines
+15
to
+20
| SIG.scan_process_range(game, main_module_range) | ||
| .map(|addr| addr + 1) | ||
| .and_then(|addr| Some(addr + 0x4 + game.read::<i32>(addr).ok()?)) | ||
| .and_then(|addr| game.read::<Address32>(addr + 0x16A).ok()) | ||
| .and_then(|addr| game.read::<Address32>(addr).ok()) | ||
| .map(|addr| addr.into()) |
There was a problem hiding this comment.
Is there a reason you are using so much and_then chaining instead of just using the ? operator
There was a problem hiding this comment.
It allows me to capture the variable and put it inside the closure.
Otherwise I would need to define a new variable each time.
Functionally the same, but I find this easier to read as I am explicitly writing in the closure what I want to do with the captured variable.
|
For the record, I haven't merged this because I haven't tested the code yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some PS1 sigscans, especially for retroarch and PCSX_rearmed, re-enabling support for those emulators