Skip to content

chore: bump QuickJS NG to 0.11 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShrBox merged 2 commits into from
Jan 10, 2026
Merged

chore: bump QuickJS NG to 0.11 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06cb860
chore: bump quickjs-ng to 0.11
Yushu2606 Dec 30, 2025
26fb193
fix: simplify array checks by removing unnecessary context parameter
Yushu2606 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/QuickJs/QjsLocalReference.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ ValueKind Local<Value>::getKind() const {

if (JS_IsFunction(context, val_)) {
return ValueKind::kFunction;
} else if (JS_IsArray(context, val_)) {
} else if (JS_IsArray(val_)) {
return ValueKind::kArray;
} else if (isByteBuffer()) {
return ValueKind::kByteBuffer;
Expand All @@ -145,7 +145,7 @@ bool Local<Value>::isBoolean() const { return JS_IsBool(val_); }

bool Local<Value>::isFunction() const { return JS_IsFunction(qjs_backend::currentContext(), val_); }

bool Local<Value>::isArray() const { return JS_IsArray(qjs_backend::currentContext(), val_); }
bool Local<Value>::isArray() const { return JS_IsArray(val_); }

bool Local<Value>::isByteBuffer() const {
if (!isObject()) return false;
Expand Down
2 changes: 1 addition & 1 deletion backend/QuickJs/QjsNative.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Local<Array> ScriptClass::getInternalStore() const {
auto obj = internalState_.weakRef_;
auto store = JS_GetProperty(context, obj, symbol);
qjs_backend::checkException(store);
if (!JS_IsArray(context, store)) {
if (!JS_IsArray(store)) {
JS_FreeValue(context, store);
store = JS_NewArray(context);
qjs_backend::checkException(store);
Expand Down
2 changes: 1 addition & 1 deletion xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if is_config("backend", "Lua") then
add_requires("lua v5.4.7", {configs={shared=true}})

elseif is_config("backend", "QuickJs") then
add_requires("quickjs-ng v0.8.0", {configs={shared=true, libc=true}})
add_requires("quickjs-ng v0.11.0", {configs={shared=true, libc=true}})

elseif is_config("backend", "Python") then
add_requires("python 3.12.8", {configs={shared=true}})
Expand Down