-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF-4165: Create animal creation summary container #3382
LF-4165: Create animal creation summary container #3382
Conversation
aefc79e
to
c7d84b0
Compare
* update tests
c7d84b0
to
7bdea5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Duncan! I thought the animal basics would be the only full width page! 😳 Do you think all the pages in this flow should be full width?? |
@SayakaOno I don't know about all pages, I am just seeing in figma that it looks full width. Maybe I am seeing the wrong part of figma |
@Duncan-Brain and @SayakaOno that is the correct part of Figma! Those summary screens at the bottom are the most recent ones Loïc made. |
White background...! Thank you both, I think merging the integration fixed it! |
@@ -0,0 +1,211 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!! 😍 Did you make the tests while you were actually writing the util functions?
I miss TDD 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 😊 Yes, I wrote the tests while I was writing the functions.
We don't always have tasks that need tests, but they can be really handy sometimes! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!! And functions perfectly merged with your other branch too 😉
Description
(to run tests:
pnpm test src/tests/animalUtils.test.js
)AddAnimalSummary
containerJira link: https://lite-farm.atlassian.net/browse/LF-4165
Type of change
How Has This Been Tested?
Until API calls are integrated,
packages/webapp/src/containers/Animals/AddAnimals/index.tsx
formResultData
inpackages/webapp/src/containers/Animals/AddAnimals/AddAnimalSummary/index.tsx
:Sample responses
Checklist: