Lf 3773 the user is able to edit the already deleted expense

[gursimran-singh]

Description

When two users are logged on to the same farm and one user begins to edit the expense while another user delete/retire the same expense, the first uses is able to save the expense even if it is deleted. It was expected that the user won’t have a possibility to edit the already deleted expense. In this case an error snackbar message should be displayed.

Jira link:https://lite-farm.atlassian.net/browse/LF-3773

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Login with two different users the onto same farm and try to edit the expense. Meanwhile, if another user delete the same expense, then first user will get an error message explaining the situation on saving the expense.

• Passes test case
• UI components visually reviewed on desktop view
• UI components visually reviewed on mobile view
• Other (please explain)

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The precommit and linting ran successfully
• I have added or updated language tags for text that's part of the UI
• I have added "MISSING" for all new language tags to languages I don't speak
• I have added the GNU General Public License to all new files

[Duncan-Brain]

This works really well for me and fixes the error well.

I was actually seeing a different scenario than the Jira ticket -- on integration I see both a success and an error message with he database successfully updating.

The get method in the saga after success snackbar was failing and so after the success message runs I would see the error message too.

My only concern is the length of the message being too long for the duration of the snackbar!

[SayakaOno]

Looks good, thank you!

@Duncan-Brain I tried running pnpm i18n to sort the translation keys alphabetically, but it made a lot of changes (it replaced the space before "?" in fr with \u00a0, and added SPECIES_COUNT_many). I will bring this up in the tech daily on Tuesday to hear your suggestions!

[Duncan-Brain]

Thanks Gursimran!