Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 3.6.5 Translations Delete #3276

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

kathyavini
Copy link
Collaborator

Description

Deletion of unused keys from the en translation file, identified via crowdin normalization in #3274

Jira link: none

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Jun 26, 2024
@kathyavini kathyavini requested review from a team as code owners June 26, 2024 17:42
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team June 26, 2024 17:42
Duncan-Brain
Duncan-Brain previously approved these changes Jun 26, 2024
@kathyavini
Copy link
Collaborator Author

@Duncan-Brain so per the discussion in Slack, it would be better to apply this to integration, right? And then apply the merge to patch? Just asking because you approved this version but maybe you didn't see it was set to patch base branch.

@Duncan-Brain
Copy link
Collaborator

@kathyavini for me either is fine!

@kathyavini kathyavini force-pushed the patch_3.6.5_translations_delete branch from dcc4cad to 44a73bd Compare June 26, 2024 18:56
@kathyavini kathyavini changed the base branch from patch/3.6.5 to integration June 26, 2024 18:57
@kathyavini kathyavini dismissed Duncan-Brain’s stale review June 26, 2024 18:57

The base branch was changed.

@kathyavini kathyavini added this pull request to the merge queue Jun 26, 2024
Merged via the queue into integration with commit 34e0a13 Jun 26, 2024
1 check passed
SayakaOno pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants