Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation from AgroSolarEurope #3223

Closed

Conversation

mvavrovic
Copy link
Collaborator

Description

German translation and changes to enable it to be selected.
Normalizes other locales, not 100% sure correctly :)

Jira link:
/

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@mvavrovic mvavrovic requested review from a team as code owners June 6, 2024 10:47
@mvavrovic mvavrovic requested review from Duncan-Brain and SayakaOno and removed request for a team June 6, 2024 10:47
@Duncan-Brain
Copy link
Collaborator

Thank you so much @mvavrovic for making this PR! Awesome to see a new language officially supported!

@dtrapplitefarm mentioned he is planning on getting a second set of eyes on the scientific translations as a second reviewer before merge!

@mvavrovic
Copy link
Collaborator Author

@Duncan-Brain Sure, especially the new animal related translations should be checked. I've only added them yesterday when I started merging your recent changes.

@kathyavini kathyavini changed the base branch from integration to german-translation-branch July 30, 2024 17:03
@kathyavini kathyavini changed the base branch from german-translation-branch to integration July 30, 2024 17:20
kathyavini added a commit that referenced this pull request Jul 30, 2024
kathyavini added a commit that referenced this pull request Jul 30, 2024
kathyavini added a commit that referenced this pull request Sep 4, 2024
This commit integrates the useLanguageOptions hook contributed by @mvavrovic in PR #3223 and adds the 3 other new LiteFarm languages to it.

Co-authored-by: mvavrovic <[email protected]>
Duncan-Brain pushed a commit that referenced this pull request Sep 6, 2024
This commit integrates the useLanguageOptions hook contributed by @mvavrovic in PR #3223 and adds the 3 other new LiteFarm languages to it.

Co-authored-by: mvavrovic <[email protected]>
@Duncan-Brain
Copy link
Collaborator

Closing this PR as German translations are now released on production in v3.6.7! https://github.com/LiteFarmOrg/LiteFarm/releases/tag/v3.6.7

Thanks again for all your work here @mvavrovic and AgroSolar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants