This change will show the created product during the completion of a Soil Amendment, Clean or Pest Contol task. #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
den4ik1203
requested review from
Duncan-Brain and
kathyavini
and removed request for
a team
SayakaOno
reviewed
May 24, 2024
|
|
||
| return ( | ||
| <HookFormPersistProvider> | ||
| <PureCompleteStepOne | ||
| key={products.length} // Adding key prop to force re-render |
There was a problem hiding this comment.
I think this is a good solution, but if you add an existing product and then modify its supplier, the change in supplier will not be reflected on the completion page.
SayakaOno
reviewed
May 24, 2024
| import { setPersistedPaths } from '../../hooks/useHookFormPersist/hookFormPersistSlice'; | ||
| import { getProducts } from '../saga'; | ||
|
|
||
| function generateProductsKey(products) { | ||
| return products.map((product) => `${product.product_id}-${product.supplier}`).join('-'); |
There was a problem hiding this comment.
I don't think this solution is maintainable or scalable. We would need to update this function every time a new field is added, like NPK.
One way to go about it is to include all fields in the key using Object.values(product).join('-');, but the key will be very long. I would suggest you go in a different direction.
We can discuss this in dev standup next week!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will show the created product during the completion of a Soil Amendment, Clean or Pest Contol task.
Jira link: https://lite-farm.atlassian.net/browse/LF-4228
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: