Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4022 custom sign up #3173

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

LF-4022 custom sign up #3173

wants to merge 2 commits into from

Conversation

antsgar
Copy link
Collaborator

@antsgar antsgar commented Mar 28, 2024

Description

Second example for guidance of navigation changes, refer to PR #3158 for more info!

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini marked this pull request as ready for review April 2, 2024 15:58
@kathyavini kathyavini requested review from a team as code owners April 2, 2024 15:58
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team April 2, 2024 15:58
@Duncan-Brain
Copy link
Collaborator

It sounds like we are interested in punting this one to the future.

Looking at this I am thinking I would prefer to opt for Anto's second solution in the RFC of multiple urls. Because this is critical to new users I am hesitant to change this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants