Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] LF-3830: Write migrations to resolve historical issues with harvest task wages #3117

Draft
wants to merge 1 commit into
base: integration
Choose a base branch
from
Draft

[WIP] LF-3830: Write migrations to resolve historical issues with harvest task wages #3117

wants to merge 1 commit into from
+135 −0

Conversation

SayakaOno
Copy link
Collaborator

Description

  • create audit_log table that keeps changes on the migration
  • update override_hourly_wage of incomplete tasks where the value is "wrong"
  • add assignee's wages to completed tasks where wage_at_moment is null

Jira link: https://lite-farm.atlassian.net/browse/LF-3830

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

TODO

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno added the bug Something isn't working label Feb 7, 2024
@SayakaOno SayakaOno self-assigned this Feb 7, 2024
SayakaOno
SayakaOno commented Feb 8, 2024
View reviewed changes
packages/api/db/migration/20240202225512_harvest_task_wage_fixes.js
const { task_id, wage_at_moment, wage } = task;
const newWage = wage.amount || 0;

// Update incomplete task
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: *complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SayakaOno SayakaOno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@SayakaOno