Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gophercloud to the latest greatest v2 #118

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

EmilienM
Copy link
Contributor

This PR bumps the Gophercloud library so you have the latest greates from it.

2 commits: the bump and the code changes needed for v2, all minor.

  • [vendoring] bump gophercloud to v2
  • Code changes for Gophercloud v2

@EmilienM
Copy link
Contributor Author

cc @Lirt

@Lirt
Copy link
Owner

Lirt commented Nov 15, 2024

Hello @EmilienM,

thank you for generous contribution.

I will fully look into it in the next days but I had a quick look around and I see that you committed /vendor directory. Is this somehow important to be added in this project? We have a very simple dependency list and I don't understand what is this supposed to solve or improve.

* `go.mod`: bump gophercloud & utils
* `go mod tidy && go mod vendor`
@EmilienM
Copy link
Contributor Author

thank you for generous contribution.

My pleasure. Just so you know, I'm a Gophercloud maintainer and a Red Hat employee who is interested to add this plugin into our downstream product.

I will fully look into it in the next days but I had a quick look around and I see that you committed /vendor directory. Is this somehow important to be added in this project? We have a very simple dependency list and I don't understand what is this supposed to solve or improve.

I didn't realize you were not vendoring 🤦‍♂️ . I removed the directory.
Thanks

@Lirt
Copy link
Owner

Lirt commented Nov 15, 2024

😃 That's fine.

I remember you from my devstack-action PR 👍.

@EmilienM
Copy link
Contributor Author

Oh right, EmilienM/devstack-action#9
hi !
Small world :)

@Lirt
Copy link
Owner

Lirt commented Nov 17, 2024

I see that we also need to bump go version in CI, can you please change it?

  • .github/workflows/tests.yaml
  • docker/Dockerfile

I will need to spend some time bumping CI deps later on.

@Lirt Lirt merged commit edc05cf into Lirt:master Nov 19, 2024
3 checks passed
@Lirt
Copy link
Owner

Lirt commented Nov 19, 2024

Everything looks good.

Thank you for contribution 🙏 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants