Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS workflow support #587

Merged
merged 25 commits into from
Feb 10, 2024
Merged

iOS workflow support #587

merged 25 commits into from
Feb 10, 2024

Conversation

fritzlb
Copy link
Contributor

@fritzlb fritzlb commented Feb 9, 2024

updated build.yml to support building for iOS. Butterfly on iOS can be sideloaded using altstore (or sth similar) but is not stable at all atm, things like trying to access the camera result in a crash.

Partially solves #244

Copy link

vercel bot commented Feb 9, 2024

@fritzlb is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

It would be nice if you could add a docs/community/download/ios.md file and link it on the download site (you can copy the content of macos.md). I would only release nightly versions with it. Here it would be cool if you can add a guide how to install it.
On this download page you could link to the issue where we can post new updates.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview Feb 10, 2024 3:32pm

@fritzlb
Copy link
Contributor Author

fritzlb commented Feb 10, 2024

I added iOS.md, the minimum target is 12.0 and updated the iOS building instructions. Is there anything else that needs to be done?

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Feb 10, 2024

If you add the download-artifact to deploy and the binary to Deploy nightly, I can merge it.
On the ios download page, the file name is wrong, it needs to be changed to linwood-butterfly-ios.ipa.

Do you want to add the Uniform Type Identifiers to all XTypeGroups (you can search for this in the code)?
Otherwise I will try to add it after merging the pr

@CodeDoctorDE
Copy link
Member

ios.md has an error:

Cause: Unexpected closing slash `/` in tag, expected an open tag first

@fritzlb
Copy link
Contributor Author

fritzlb commented Feb 10, 2024

the deployment section should be fixed by now, I'd probably have to set up sth to test it.
the links in ios.md are fixed, note to self: just because a browser correctly displays <a href></a> doesn't mean I should use it in markdown.

I have pretty much no experience with uniform type identifiers so I'd be cool if you could add them :)
Also thank you so much for your feedback, in the last two days I learned more about github actions than ever before :)

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Feb 10, 2024

Thanks for your contribution!
Without your help, there would be no iOS support.
I also need to research a bit. On the file selector pub package, it says it needs to have it to work on iOS.
I will merge it this evening. Feel free to contribute more.
There is another ci issue currently opened about a wrong nightly check.

One small tip: it is a bit harder to review the changes if you commit on every small change

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me!

@CodeDoctorDE CodeDoctorDE merged commit 1355769 into LinwoodDev:develop Feb 10, 2024
15 checks passed
@CodeDoctorDE CodeDoctorDE linked an issue Feb 10, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature request]: Stabilize iOS support
2 participants