Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve pdf export problem #584

Closed
wants to merge 3 commits into from
Closed

solve pdf export problem #584

wants to merge 3 commits into from

Conversation

MrGumpIT
Copy link
Contributor

@MrGumpIT MrGumpIT commented Feb 5, 2024

i try it on windows and android he works correctly, scale factor is no longer necessary, you should change the dropdown menu to have the user select landscape mode.

Copy link

vercel bot commented Feb 5, 2024

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

@CodeDoctorDE
Copy link
Member

Hmm, but the idea was that the pdf page is the same size as the area to have a similar export behavior as image and svg. Now it is a4 no matter how the area was before. And I don't see the dpi anywhere relevant? The exact slider value is just the visual representation of the tool.constrainedWidth

@MrGumpIT
Copy link
Contributor Author

MrGumpIT commented Feb 5, 2024

Maybe I misunderstood, I understood that the objective was to obtain an A4 sized page on which the area with the drawings were correctly shown. The dpi is multiplied by the height and width in area.dart to make sure that the drawing area always has the same physical size on all devices, also I tried to use the same dimensions for the area and l image but there is something that breaks because I get large white borders around the image or a small image in different positions of the pdf

@CodeDoctorDE
Copy link
Member

Yeah, but maybe the FullPage and the fit: fill should work?

@MrGumpIT
Copy link
Contributor Author

MrGumpIT commented Feb 5, 2024

Mhh I don't know, I also tried to provide fixed dimensions, and while the other exports worked and gave the correct dimensions, the PDF export didn't, because the page always has different dimensions even if the page is created with the same area dimensions. This seemed like the best and most functional solution to me

@CodeDoctorDE
Copy link
Member

I close this pr now to keep it clean here. If you have another fix feel free to open a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants