Fix shape detection list tile not clickable

LinwoodDev · Jan 4, 2025 · 7ebb51c · 7ebb51c
1 parent 10495be
commit 7ebb51c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/app/lib/dialogs/background/dialog.dart b/app/lib/dialogs/background/dialog.dart
@@ -105,7 +105,7 @@ class BackgroundDialog extends StatelessWidget {
                 onPressed: () => Navigator.of(context).pop(),
               ),
               ElevatedButton(
-                child: Text(MaterialLocalizations.of(context).okButtonLabel),
+                child: Text(AppLocalizations.of(context).save),
                 onPressed: () {
                   context.read<DocumentBloc>().add(DocumentBackgroundsChanged(
                       [if (background != null) background!]));

diff --git a/app/lib/dialogs/constraints.dart b/app/lib/dialogs/constraints.dart
@@ -67,14 +67,12 @@ class _ConstraintsViewState extends State<ConstraintsView> {
       children: [
         ExpansionPanel(
           isExpanded: opened,
+          canTapOnHeader: true,
           headerBuilder: (context, isExpanded) => Wrap(
             children: [
               ListTile(
                 title: Text(AppLocalizations.of(context).constraints),
                 leading: const PhosphorIcon(PhosphorIconsLight.selection),
-                onTap: () => setState(() {
-                  opened = !isExpanded;
-                }),
                 trailing: DropdownMenu<String>(
                   dropdownMenuEntries: all.entries
                       .map((e) => DropdownMenuEntry(

diff --git a/app/lib/dialogs/sync.dart b/app/lib/dialogs/sync.dart
@@ -62,6 +62,7 @@ class _SyncDialogState extends State<SyncDialog> {
                       children: [
                         ...service.syncs.asMap().entries.map((entry) =>
                             ExpansionPanel(
+                                canTapOnHeader: true,
                                 isExpanded: _openedPanels.contains(entry.key),
                                 headerBuilder: (context, isExpanded) =>
                                     ListTile(

diff --git a/app/lib/selections/tools/pen.dart b/app/lib/selections/tools/pen.dart
@@ -54,6 +54,7 @@ class __ShapeDetectionViewState extends State<_ShapeDetectionView> {
       },
       children: [
         ExpansionPanel(
+          canTapOnHeader: true,
           headerBuilder: (BuildContext context, bool isExpanded) {
             return ListTile(
               title: Text(AppLocalizations.of(context).shapeDetection),

diff --git a/metadata/en-US/changelogs/127.txt b/metadata/en-US/changelogs/127.txt
@@ -19,5 +19,6 @@
 * Fix grid not working correctly
 * Fix capture thumbnail uses wrong position
 * Fix zoom slider is not centered
+* Fix shape detection list tile not clickable
 
 Read more here: https://linwood.dev/butterfly/2.3.0-beta.0