Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (and silence) a bunch of build-time diagnostics ("warnings") #1278

Merged
merged 20 commits into from
Aug 21, 2022
Merged

Fix (and silence) a bunch of build-time diagnostics ("warnings") #1278

merged 20 commits into from
Aug 21, 2022

Commits on Aug 21, 2022

  1. Add a test of halcmd with backslash continuations

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    c3cd5a5 View commit details
    Browse the repository at this point in the history

  2. build: Silence format-truncation and stringop-truncation 

    We deliberately use truncating formats and string operations, this
is not something the compiler should warn us about.
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    acbb926 View commit details
    Browse the repository at this point in the history

  3. Turn off deprecated header messages 

    These occur internally to boost::python headers.
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    667e27d View commit details
    Browse the repository at this point in the history

  4. emclcd etc: fix overwriting errors into truncating ones

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    ba637ba View commit details
    Browse the repository at this point in the history

  5. classicladder: Don't tell us about deprecated (gtk2) types

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    b7320c3 View commit details
    Browse the repository at this point in the history

  6. halrmt: fix some compiler diagnostics

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    35a5f93 View commit details
    Browse the repository at this point in the history

  7. miscgtk: don't implement strdup

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    04690b3 View commit details
    Browse the repository at this point in the history

  8. halcmd: fix string diagnostics in backslash handling

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    27bd839 View commit details
    Browse the repository at this point in the history

  9. Fix more warnings from boost

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    b9f1662 View commit details
    Browse the repository at this point in the history

  10. Remove unused variable

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    178e0ff View commit details
    Browse the repository at this point in the history

  11. Fix snprintf sizeof() to match argument exactly 

    4/5 based on a review comment by seb, 1 more caught by grep
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    062939c View commit details
    Browse the repository at this point in the history

  12. this rule is for rip-builds 

    .. so rename it. I don't know if anyone is using the rule, but if so
they have to adjust their manual process

This also fixes the build-time diagnostic
```
Makefile:865: warning: overriding recipe for target 'install-menu'
Makefile:648: warning: ignoring old recipe for target 'install-menu'
```
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    73ea930 View commit details
    Browse the repository at this point in the history

  13. emcTaskStateRestore: return a useful(?) result 

    .. it's ignored in the caller, but this should be the return value.
It quiets a diagnostic about res being assigned but not used.
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    64d87d2 View commit details
    Browse the repository at this point in the history

  14. Don't build tpcomp, it's only useful out-of-tree 

    .. the manpage is still generated.

This is done simply to get rid of the diagnostic message when it's built
in-tree.

I considered the alternative of providing a TOPDIR value during build,
but as I would only be able to test it during a uspace build I decided
not to do so. I'd be happy to see it done as a substitute, though, as
otherwise the component is likely to bitrot.
    @jepler
    jepler committed Aug 21, 2022
    3 Configuration menu
    Copy the full SHA
    07e1e99 View commit details
    Browse the repository at this point in the history

  15. Fix the one format-truncation diagnostic & re-enable it

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    89e8237 View commit details
    Browse the repository at this point in the history

  16. Size error buffers the same 

    .. it quiets some stringop-truncation diagnostics
    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    5d66f94 View commit details
    Browse the repository at this point in the history

  17. inivar: get rid of LINELEN-sized buffers where unneeded

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    185e9ae View commit details
    Browse the repository at this point in the history

  18. use error_buf_size

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    6a098a0 View commit details
    Browse the repository at this point in the history

  19. These diagnostics have all been fixed!

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    e489bc2 View commit details
    Browse the repository at this point in the history

  20. Explain why these items are silenced ("tag - you're it!")

    @jepler
    jepler committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    ac62308 View commit details
    Browse the repository at this point in the history