C89 and CMake #22
Open
C89 and CMake #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add missing headers for sym
…headers; [README.md] Reflect C89
…uild two targets (library and executable)
…nker error by using `extern` (in the header) and providing the storage in one place (the implementation)
…MakeLists.txt] Rename exec and lib to reflect README; [src/waxc.c] Use `EXIT_SUCCESS` as inverse to my earlier `EXIT_FAILURE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LingDong- So I added C89 support and integrated CMake. Whilst I was at it, I implemented header files for all your files, being careful to only add protoypes for functions and globals that are used in more than the implementation file.
Builds tested on: macOS (AppleClang) and Windows (MSVC).