Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test case ut_lind_fs_open_empty_directory #57

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ChinmayShringi
Copy link
Contributor

Description

Fixes # (issue)

This PR addresses the issue where an empty string "" passed as a file path was incorrectly classified as a directory, returning EISDIR (Is a directory). The changes ensure that the correct error (ENOENT - No such file or directory) is returned when an empty path is provided.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • The fix has been tested by running the specific test case: cargo test ut_lind_fs_open_empty_directory, which verifies that providing an empty path correctly results in ENOENT and not EISDIR.

Checklist

  • My code follows the style guidelines of this project.
  • I have thoroughly commented my code, especially in hard-to-understand areas.
  • I have performed a self-review of my code and fixed all errors and warnings.
  • I have added appropriate tests for the functionality or bug fix.
  • My changes do not introduce any new warnings.
  • Dependent changes have been added to the pull request or merged (native-client, lind-glibc, lind-project).
  • Documentation has been updated (if applicable).

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yaxuan-w Yaxuan-w merged commit d7f776b into main Oct 17, 2024
1 check failed
@Yaxuan-w Yaxuan-w deleted the fix-ut-lind-fs-open-empty-directory branch October 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants