This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Log parser: Reduce name repetition #1144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a test name regex to extract parts of the log parser outputs to produce more meaningful test names. Instead of producing test names with the "REGEX_NAME" + SHA, create test names with "REGEX_NAME"+"REGEX_EXTRACT_NAME"+SHA to make the test names easier to interpret. Example test name before: check-kernel-oops-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220 Example test name after: check-kernel-oops-oops-bug-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220 Signed-off-by: Katie Worton <[email protected]>
Move the meaningful name extracted by the REGEX_EXTRACT_NAME regex to be included in the "higher-level" test name. Before, test names would look like: "check-kernel-oops" And these would then be broken down into smaller test buckets with names like: "check-kernel-oops-oops-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220" Now, the higher-level test would be called: "check-kernel-oops-oops-preempt-smp" And the broken down tests would still look like: "check-kernel-oops-oops-preempt-smp-a1acf2f0467782c9c2f6aeadb1d1d3cec136642b13d7231824a66ef63ee62220" This makes the higher-level test names more meaningful, then if there are differences which are not captured by the higher-level name, the SHA can be used to differentiate the different cases. Signed-off-by: Katie Worton <[email protected]>
Add an extra test case for multiple failures with SHAs. Signed-off-by: Katie Worton <[email protected]>
Change the log parser regexes so there is less repetition in the name. Instead of "check-kernel-oops-oops-preempt-smp" naming would be "check-kernel-oops-preempt-smp". Signed-off-by: Katie Worton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the log parser regexes so there is less repetition in the name.
Instead of "check-kernel-oops-oops-preempt-smp" naming would be "check-kernel-oops-preempt-smp".