api: test_rest: result: add skip filter #1132
Conversation
| def test_tests_filter_by_result_pass(self): | ||
| data = self.hit('/api/tests/?result=true') | ||
| self.assertEqual(list, type(data['results'])) | ||
| self.assertEqual(50, len(data['results'])) |
There was a problem hiding this comment.
Is this 50 because we limit results to 50 per page? I can see the other tests have this too, but couldn't see where it came from.
There was a problem hiding this comment.
Hi @katieworton , you got that one right! https://github.com/Linaro/squad/blob/master/squad/settings.py#L412
By default, REST API page size is 50. They are all created on the top of that file: https://github.com/Linaro/squad/blob/master/test/api/test_rest.py#L109-L137
There was a problem hiding this comment.
Perfect - thanks for confirming!
Perhaps the 50 should be read from a variable in the tests so it's clearer where it comes from, but that's a separate task :)
This will make it possible to filter on skip's too which should be: https://qa-reports.linaro.org/api/tests/?result__isnull=true Signed-off-by: Anders Roxell <[email protected]>
|
This looks good, the failures are due to a recent release of DRF which breaks squad testing. I'll send a patch to fix that later today. |
No description provided.