Also fetch LAVA job definition for watchjobs

[swvanbuuren]

Currently, the LAVA job definition is only fetched if the LAVA job is submitted directly through SQUAD (i.e. using a submitjob). This commit also implements this functionality for watchjobs.

[mwasilew]

LGTM

[chaws]

LGTM

[chaws]

Tests are failing because the testing backend is missing get_job_definition(). I came up with a quick fix in case you want to use it:

diff --git a/squad/ci/backend/fake.py b/squad/ci/backend/fake.py
index e49556bb..4b3100e2 100644
--- a/squad/ci/backend/fake.py
+++ b/squad/ci/backend/fake.py
@@ -66,5 +66,8 @@ class Backend(object):
     def check_job_definition(self, definition):
         return True
 
+    def get_job_definition(self, test_job):
+        return "sample job definition"
+
     def supports_callbacks(self):
         return False
diff --git a/test/api/test_ci.py b/test/api/test_ci.py
index 6ee36946..ba19fce3 100644
--- a/test/api/test_ci.py
+++ b/test/api/test_ci.py
@@ -238,6 +238,8 @@ class CiApiTest(TestCase):
             1,
             testjob_queryset.count()
         )
+        testjob = testjob_queryset.first()
+        self.assertTrue(len(testjob.definition) > 0)
         fetch.assert_called_with(testjob_queryset.first().id)
         logentry_queryset = LogEntry.objects.filter(
             user_id=self.project_privileged_user.pk,

[swvanbuuren]

Tests are failing because the testing backend is missing get_job_definition(). I came up with a quick fix in case you want to use it:

diff --git a/squad/ci/backend/fake.py b/squad/ci/backend/fake.py
...

Thank you for this. I have taken over your suggestion in commit f81c12f.

Tests seem to have passed.