Kir: Update docker image to pull #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will stop us pulling from DockerHub. Right now kir is already pulled on the workers so this won't break anything. However LAVA source code needs to change to introduce pulling if the image is not there. Signed-off-by: Benjamin Copeland <[email protected]>
|
This will also break kir when we do changes to image (as in it won't pull in the latest image). Anders, you will have to change KIR to do releases, right now it uses :master. We will need to add a release, so we can pull in a version. |
Now KIR has a tag release, we should pull that release. Signed-off-by: Benjamin Copeland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will stop us pulling from DockerHub. Right now kir is already pulled on the workers so this won't break anything. However LAVA source code needs to change to introduce pulling if the image is not there.