-
Notifications
You must be signed in to change notification settings - Fork 23
Add ISM-X optional attestation bridge (v0.3.1) — DB & CLI integration #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! 👋 |
|
First off, thank you for putting in the time and effort to build this attestation and capability-lease layer — it’s clear there’s been a lot of thought put into the security design and documentation. That said, this PR introduces significant architectural changes that go beyond the current project scope. It modifies core access flows and dependencies (e.g., introducing new verification endpoints, passport signing, and external key management), which could affect maintainability and existing integrations. Before merging something of this magnitude, I’d like to:
Could you please open a short design discussion or ADR (Architecture Decision Record) summarizing:
Once that’s available, we can review as a team and decide whether to merge, refactor into an experimental branch, or stage the changes incrementally. Thanks again for contributing — this is a valuable direction to explore, but I want to make sure it aligns with the project roadmap. |
|
Thanks for the thoughtful review — agreed on scope and maintainability. Proposed plan:
If that direction sounds good, I’ll push the refactor and ADR shortly. |
Thanks @Freeky7819 — that sounds like a solid plan. 👍 Once the refactor and ADR are up, I’ll take a look and we can review it as a self-contained feature branch — no rush on merging, just want to make sure everything stays stable and consistent with the current goals. Thanks again for being proactive and flexible. |
Summary
This PR adds an optional attestation layer to protect database access in MCP-for-Database.
It uses Ed25519-signed “passports” and HMAC-SHA256 commitments with short-lived, single-use capability leases (replay protection). A remote /verify endpoint is preferred; a local verification fallback is provided.
What’s included
How to use (quick)
pip install requests pynacl httpx fastapi "python-jose[cryptography]" pytest