fix: disallow sending preconf txs with future nonces #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failfmi
approved these changes
Aug 28, 2024
radkomih
force-pushed
the
refactor/move-txlist-trigger-in-geth
branch
from
31bb8fb
to
4a9d969
Compare
failfmi
pushed a commit
that referenced
this pull request
Oct 16, 2024
* get slots and tx list config from storage * add MaxProposedTxListsPerEpoch param * refactor * revert flags * fix: non-initialized snapshot * fix: return errors and refactor * refactor: calc current slot/epoch and store assigned slots * refactor * update L1 genesis timestamp * wip: refactor * fixes * use lock for slot estimates * remove tx for missed slots * fixes * refactor worker locks * handle other non-preconf txs * fix: disallow sending preconf txs with future nonces (#13) * update/reset txslotsnapshot gas/bytes * fix proposing non-preconf txs * fix: update geth internal_l2 genesis * simulate txs per slot and calc gas/bytes * fix processing of future epoch slots * rework workers & locks. remove logging goroutine. script for spamming * fix preconf tx hash * remove slot offset * fix 0 slot * fix block number in preconf receipts --------- Co-authored-by: Vladimir Trifonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow pre-confirmation txs with future nonces, since there is no guarantee that they will be valid and included in a block