Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: building tx lists #11

Merged
merged 27 commits into from
Oct 16, 2024
Merged

refactor: building tx lists #11

merged 27 commits into from
Oct 16, 2024

Conversation

radkomih
Copy link
Collaborator

@radkomih radkomih commented Aug 21, 2024 •
edited
Loading

Geth

  • prepare tx lists in separate goroutine
  • simulate and build preconf tx snapshots per slot
  • simulate and build non-preconf tx pool snapshot
  • calculate/reset gas/bytes usage properly
  • change block gas limit from 30_000_000 to blockMaxGasLimit in web api
  • refactor preconf types and storage
  • refactor tx snapshot locks in worker
  • fix unhandled errors
  • return txs for specific slot and current non-preconf txs
  • fix preconf tx hash
  • implement inclusion in the current or future slots (without the min offset)
  • handle preconf txs for missed slots
  • disallow accepting preconf txs with future nonces
  • store preconf receipt with the correct block number
  • expose rpc method for updating the txlist config, genesis time and assigned slots
  • expose rpc method for getting the assigned slots and l1 genesis timestamp (for testing)
  • remove some of the logs
  • TODO(limechain)

Tests scripts

  • send spam or prepared set of txs

@radkomih radkomih self-assigned this Aug 21, 2024
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 3d2868f to cd2344e Compare August 21, 2024 11:38
failfmi
failfmi reviewed Aug 22, 2024
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
failfmi
failfmi reviewed Aug 22, 2024
View reviewed changes
eth/taiko_api_backend.go Outdated Show resolved Hide resolved
failfmi
failfmi reviewed Aug 22, 2024
View reviewed changes
eth/taiko_api_backend.go Outdated Show resolved Hide resolved
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch 2 times, most recently from ad290b2 to 8228aea Compare August 26, 2024 07:12
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch 2 times, most recently from 80f45b8 to 294e87e Compare August 27, 2024 06:18
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 294e87e to a7bcc3a Compare August 27, 2024 06:20
failfmi
failfmi reviewed Aug 28, 2024
View reviewed changes
core/rawdb/preconf_l1_epoch_slots.go Outdated Show resolved Hide resolved
core/rawdb/preconf_l1_genesis_timestamp.go Outdated Show resolved Hide resolved
@radkomih radkomih changed the title Refactor/move txlist trigger in geth refactor/move tx list building in geth and additional changes Sep 19, 2024
@radkomih radkomih changed the title refactor/move tx list building in geth and additional changes refactor: move tx list building in geth and additional changes Sep 19, 2024
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 2e99f47 to 31bb8fb Compare September 19, 2024 09:13
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 31bb8fb to 4a9d969 Compare September 19, 2024 09:15
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 3c3142d to 94e4e5d Compare September 26, 2024 09:57
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 25746dd to a98361f Compare September 26, 2024 14:24
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 482491e to 8d71c3b Compare September 30, 2024 08:42
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 154986f to 2d39608 Compare October 2, 2024 09:55
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 0fbdc27 to 718c9ed Compare October 14, 2024 05:35
@radkomih radkomih changed the title refactor: move tx list building in geth and additional changes refactor: building tx lists Oct 15, 2024
@radkomih radkomih force-pushed the refactor/move-txlist-trigger-in-geth branch from 56a646a to c57708e Compare October 15, 2024 12:32
@failfmi failfmi self-requested a review October 16, 2024 10:36
@failfmi failfmi merged commit 9285a91 into dev-preconfs Oct 16, 2024
@failfmi failfmi deleted the refactor/move-txlist-trigger-in-geth branch October 16, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@failfmi failfmi failfmi approved these changes

@vladimir-trifonov vladimir-trifonov Awaiting requested review from vladimir-trifonov

Assignees

@radkomih radkomih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radkomih @failfmi @vladimir-trifonov