Mykhailo Hutsalenko Homework #1 #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimarenkoDenis
requested changes
Aug 18, 2020
| @@ -0,0 +1,3 @@ | |||
| export interface ISalary { | |||
There was a problem hiding this comment.
best practice and by conventions - filename should be salary.interface.ts
the same for another file
| className: 'open menu' | ||
| } | ||
|
|
||
| var expectedClassName: string = 'open menu new me'; |
| } | ||
|
|
||
| export function getToptPaidEmployee(salaries: ISalary): string { | ||
| let topPaidEmployee = Object.keys(salaries).reduce((function(prevEmp, nextEmp){ |
There was a problem hiding this comment.
have you set up tslint plugin to your editor?
because I have tslint warnings, pls fix
There was a problem hiding this comment.
Yes, of course. I just did not have time to refactor it all in a best practice way
| return topPaidEmployee; | ||
| } | ||
|
|
||
| export function multiplyNumeric(object : any) { |
There was a problem hiding this comment.
no any and type for function return value
fix everywhere
| addClass(obj, 'new'); // obj.className='open menu new' | ||
| addClass(obj, 'open'); // без изменений (класс уже существует) | ||
| addClass(obj, 'me'); // obj.className='open menu new me' | ||
| console.log(obj.className); |
There was a problem hiding this comment.
no console by tslint rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.