Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch license to MIT #12

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Switch license to MIT #12

merged 1 commit into from
Jun 3, 2024

Conversation

LilithHafner
Copy link
Owner

Closes #11

Approval from @lkdvos here

@devmotion
Copy link

It seems this might be good to be merged and released? 🙂

@LilithHafner LilithHafner merged commit b6e7fc9 into main Jun 3, 2024
15 checks passed
@LilithHafner LilithHafner deleted the lh/mit branch June 3, 2024 14:14
@devmotion
Copy link

Great, thank you! Could you also tag a new release with the license change?

@LilithHafner
Copy link
Owner Author

That's not necessary. Applying a license to a chunk of code (as I have just done) is the act that legally makes the code available under that license. The code in this repo right now is literally identical to the code released as 1.2.0 so folks may use that version under the terms of the MIT license if they wish.

@devmotion
Copy link

While a new release might not be required legally, it would still be helpful: Otherwise checks for dependencies with GPL licenses with eg https://github.com/ericphanson/LicenseCheck.jl will continue flagging PtrArrays as problematic.

@PatrickHaecker
Copy link

Thanks for changing the license.

Indeed having a new release would help us save some work, too. If you only want to do a new release with changed source code, you could add a reference in line 32 pointing to what exactly is buggy in Core.checked_dims.

I recognize that it creates some work on your side, but with multiple users it would still be better than a zero-sum game. And I am pretty sure creating a new release is more fun than having discussions with the legal department before shipping. :-)

@syarra
Copy link

syarra commented Aug 30, 2024

Thanks for updating the license terms!

While a new release might not be required legally, it would still be helpful: Otherwise checks for dependencies with GPL licenses with eg https://github.com/ericphanson/LicenseCheck.jl will continue flagging PtrArrays as problematic.

That would indeed be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change license to e.g. MIT?
4 participants