Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of CPC module and tests #902

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Oct 10, 2022

What does this PR do?

Fixes part of #839

Summary

  • Rewrite CPC module to be more readable
  • Remove unrelated code
  • Tests

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the model label Oct 10, 2022
@otaj otaj mentioned this pull request Oct 11, 2022
@Borda Borda force-pushed the master branch 2 times, most recently from afdc09a to c5137b4 Compare May 19, 2023 17:15
@Borda
Copy link
Member

Borda commented Jun 29, 2023

@matsumotosan how is it going here? 🐰

@matsumotosan
Copy link
Contributor Author

@Borda I am planning to get back on it.

matsumotosan and others added 7 commits July 3, 2023 21:15
…0,>4.0.0 to >4.0.0,<=4.22.1 in /requirements (Lightning-Universe#1053)

build(deps): update jsonargparse[signatures] requirement

Updates the requirements on [jsonargparse[signatures]](https://github.com/omni-us/jsonargparse) to permit the latest version.
- [Changelog](https://github.com/omni-us/jsonargparse/blob/main/CHANGELOG.rst)
- [Commits](omni-us/jsonargparse@v4.0.1...v4.22.1)

---
updated-dependencies:
- dependency-name: jsonargparse[signatures]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ements (Lightning-Universe#1054)

build(deps): bump pytest-rerunfailures in /requirements

Bumps [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) from 11.1.2 to 12.0.
- [Changelog](https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst)
- [Commits](pytest-dev/pytest-rerunfailures@11.1.2...12.0)

---
updated-dependencies:
- dependency-name: pytest-rerunfailures
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants