This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Autoscaler issue fixes; Episode 2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2022 07:05
tchaton
reviewed
Jan 9, 2023
| @@ -554,7 +558,7 @@ def scale(self, replicas: int, metrics: dict) -> int: | |||
| scale_out_interval=10, | |||
| scale_in_interval=10, | |||
| max_batch_size=8, # for auto batching | |||
| timeout_batching=1, # for auto batching | |||
| max_batch_delay=1, # for auto batching | |||
There was a problem hiding this comment.
batch_wait_interval would be slightly more explicit and consistent with the arguments above.
| @@ -598,20 +601,22 @@ def __init__( | |||
| self._last_autoscale = time.time() | |||
| self.fake_trigger = 0 | |||
|
|
|||
| for _ in range(min_replicas): | |||
There was a problem hiding this comment.
For another PR, we need to clean this out with structures. This isn't begineer friendly.
| @@ -1,12 +1,12 @@ | |||
| # !pip install 'git+https://github.com/Lightning-AI/stablediffusion.git@lit' | |||
| # !pip install 'git+https://github.com/Lightning-AI/DiffusionWithAutoscaler.git' | |||
| # !pip install 'git+https://github.com/Lightning-AI/DiffusionWithAutoscaler.git@debugging2' | |||
There was a problem hiding this comment.
To be changed before merging.
| @@ -506,7 +506,11 @@ class AutoScaler(LightningFlow): | |||
| scale_in_interval: The number of seconds to wait before checking whether to decrease the number of servers. | |||
| endpoint: Provide the REST API path. | |||
| max_batch_size: (auto-batching) The number of requests to process at once. | |||
| timeout_batching: (auto-batching) The number of seconds to wait before sending the requests to process. | |||
| max_batch_delay: (auto-batching) The number of seconds to wait before sending the requests to workers. | |||
| request_timeout: The number of seconds to wait before timing out a request. A request may timeout because of | |||
There was a problem hiding this comment.
Did you add this already ? Should this be dynamic on the number of element in the batch ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.