Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch links from PDF to abstract #305

Merged
merged 10 commits into from
Jul 20, 2024
Merged

docs: switch links from PDF to abstract #305

merged 10 commits into from
Jul 20, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 8, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

linking PDF is quite heavy and sometimes returning false check while we validate correct link

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (30b6397) to head (4c2be2f).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #305   +/-   ##
===================================
  Coverage    70%    70%           
===================================
  Files         2      2           
  Lines       403    403           
===================================
  Hits        284    284           
  Misses      119    119           

@Borda Borda force-pushed the main branch 2 times, most recently from d4acf6f to ac8f7ba Compare July 19, 2024 21:12
@Borda Borda merged commit cbbea35 into main Jul 20, 2024
14 of 24 checks passed
@Borda Borda deleted the docs/link-arxiv-abs branch July 20, 2024 08:22
@Borda Borda added the enhancement New feature or request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant