Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop flattening: remove .connect() #16384

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Loop flattening: remove .connect() #16384

merged 3 commits into from
Jan 17, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 16, 2023 •
edited by github-actions bot
Loading

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Removes Loop.connect() and the Trainer's setters

cc @justusschock @awaelchli @Borda @carmocca

@carmocca carmocca added refactor breaking change Includes a breaking change loops Related to the Loop API pl Generic label for PyTorch Lightning package labels Jan 16, 2023
@carmocca carmocca self-assigned this Jan 16, 2023
@carmocca carmocca marked this pull request as ready for review January 16, 2023 17:09
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_loops.py, tests/tests_pytorch/loops/test_training_loop.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py, docs/source-pytorch/extensions/loops.rst.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/dataloader/evaluation_loop.py, src/pytorch_lightning/loops/dataloader/prediction_loop.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/fit_loop.py, src/pytorch_lightning/loops/loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/trainer.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca mentioned this pull request Jan 16, 2023
Open
@carmocca carmocca enabled auto-merge (squash) January 16, 2023 23:32
@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2023
@carmocca carmocca merged commit 051d316 into lite/debug Jan 17, 2023
@carmocca carmocca deleted the lite/debug-connect branch January 17, 2023 02:12
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
942a1cd
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
65a8ff6
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
0aebc12
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca @Borda
Loop flattening: remove .connect() (#16384)
27d6f28
@carmocca carmocca added this to the 2.0 milestone Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
95d1057
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
02a6c4d
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Loop flattening: remove .connect() (#16384)
05876b6
lantiga pushed a commit that referenced this pull request Jan 19, 2023
@carmocca @lantiga
Loop flattening: remove .connect() (#16384)
46246c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton

@justusschock justusschock Awaiting requested review from justusschock

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carmocca @awaelchli @Borda