Fix lint:ci problems #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ import { useConfirm } from "@foxglove/studio-base/hooks/useConfirm"; | |||
|
|
|||
| const log = Logger.getLogger(__filename); | |||
|
|
|||
| export const AVATAR_ICON_SIZE = 42; | |||
| const AVATAR_ICON_SIZE = 42; | |||
There was a problem hiding this comment.
Out of curiosity: why it was changed?
There was a problem hiding this comment.
This export was never used. It is shown when using the yarn lint:unused-exports
| @@ -91,6 +91,7 @@ | |||
| "@types/uuid": "9.0.7", | |||
| "@types/wicg-file-system-access": "2020.9.6", | |||
| "@uiw/react-textarea-code-editor": "3.0.2", | |||
| "async-mutex": "0.5.0", | |||
There was a problem hiding this comment.
what is this aditional library for?
There was a problem hiding this comment.
Required when running yarn lint:dependencies
|
Can you please enhance the PR description to make it more clear the reason why those changes needed to be done to fix the pipeline? |
laisspportugal
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
After merging different versions to create a fork, we encountered several failures in the CI pipeline's lint checks. This PR addresses these issues by implementing fixes to ensure compliance with our enhanced linting rules in the CI environment. Below are the key changes made:
Description
Once we merged different versions to create the fork, some errors on lint (the lint on CI, that have more checks) started to fail. So basically it was fixed the problems found in the lint ci commands :
yarn dedupe --checkcommand identified duplicates in yarn.lock. Runningyarn dedupehas resolved these duplications.yarn lint:cicommand. These issues were not previously detected during development due to the additional lint rules applied only in the CI environment.yarn lint:unused-exportsscript helped identify and remove duplicated files and unused export statements resulting from the merge.yarn lint:dependenciesscript required adding certain libraries to the package.json within packages to meet dependency rules.These changes ensure that our codebase meets the stricter linting standards of our CI pipeline, leading to cleaner and more maintainable code.