Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show valdiate at app files #2741

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix show valdiate at app files #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fa0e5f
fix: Show validate at app files
vitormattos Apr 12, 2024
946fc8f
fix: linter
vitormattos Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Components/RightSidebar/RequestSignatureTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
</NcButton>
</div>
<VisibleElements />
<NcModal v-if="showSignModal" size="full" @close="closeModal()">
<NcModal v-if="modalSrc" size="full" @close="closeModal()">
<iframe :src="modalSrc" class="iframe" />
</NcModal>
</div>
Expand Down Expand Up @@ -111,7 +111,6 @@
hasLoading: false,
signerToEdit: {},
modalSrc: '',
showSignModal: false,
canRequestSign: loadState('libresign', 'can_request_sign', false),
}
},
Expand Down Expand Up @@ -167,9 +166,15 @@
},
methods: {
closeModal() {
this.showSignModal = false
this.modalSrc = ''
},
validationFile() {
console.log('validationFile')

Check warning on line 172 in src/Components/RightSidebar/RequestSignatureTab.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Unexpected console statement
if (this.useModal) {
const route = router.resolve({ name: 'ValidationFileExternal', params: { uuid: this.filesStore.getFile().uuid } })
this.modalSrc = route.href
return
}
this.$router.push({ name: 'ValidationFile', params: { uuid: this.filesStore.getFile().uuid } })
this.sidebarStore.hideSidebar()
},
Expand Down Expand Up @@ -209,7 +214,6 @@
if (this.useModal) {
const route = router.resolve({ name: 'SignPDFExternal', params: { uuid } })
this.modalSrc = route.href
this.showSignModal = true
return
}
this.signStore.setDocumentToSign(this.filesStore.getFile())
Expand Down
6 changes: 2 additions & 4 deletions src/views/SignPDF/_partials/ModalSMSManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,15 @@
v-model="token"
:disabled="loading"
name="code"
type="text">
</NcTextField>
type="text" />
</div>
<div v-else class="store-number">
<NcTextField v-model="newPhoneNumber"
:disabled="loading"
name="cellphone"
placeholder="+55 00 0 0000 0000"
type="tel"
@change="sanitizeNumber">
</NcTextField>
@change="sanitizeNumber" />
</div>
<template #actions>
<NcButton v-if="newPhoneNumber && !tokenRequested" :disabled="loading" @click="requestCode">
Expand Down